Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSI driver GitOps Blog Edits #246

Merged
merged 13 commits into from
Apr 9, 2024

Conversation

mikemcd3912
Copy link
Contributor

@mikemcd3912 mikemcd3912 commented Apr 9, 2024

Issue #, if available:
#203

Description of changes:

  1. Updating CSI driver manifests to use more recent Kustomization API version, reducing redundant files
  2. Re-write Tester and Snapshot files to test the VMware CSI driver instead of openebs

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mikemcd3912 mikemcd3912 changed the title CSI driver GitOps Blog CSI driver GitOps Blog Edits Apr 9, 2024
Copy link
Contributor

@elamaran11 elamaran11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikemcd3912 Lot of breaking changes, did you test it, can you confirm the addon for vSphere CSI and Testers work? Can you share screenshots?

app: vmware-csi-driver
spec:
interval: 1m0s
path: ./eks-anywhere-vsphere/Addons/Core/storage-driver/vmware-csi/vmware-csi-namespace
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need 3 Kustomizations for Ordering?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested it end to end and confirmed it works, I can test again if we'd like screenshots.

3 Kustomizations to enforce ordering was to ensure the driver would deploy after the secrets because immutability of the deployment was causing it to fail if the secret took longer than the driver. I did enable restarts however after creating this order enforcement so I'll test to see if we can simplify it with that enabled when I re-test for screenshots

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes lets get some screenshots to PR. Its lot changes so we want to make sure we document the outputs.

@elamaran11
Copy link
Contributor

@mikemcd3912 Also why do we have the GH Action failing, something we should fix?

@mikemcd3912
Copy link
Contributor Author

Failed GH action is expected behavior since I'm editing files in the Core directory rather than Partner Addons

@mikemcd3912
Copy link
Contributor Author

mikemcd3912 commented Apr 9, 2024

image

Simplified Kustomization & File structure testing was successful

Copy link
Contributor

@elamaran11 elamaran11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elamaran11 elamaran11 merged commit ee7ec16 into aws-samples:main Apr 9, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants