-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address DiscoverySelectors
conflict
#261
Address DiscoverySelectors
conflict
#261
Conversation
Signed-off-by: Petr McAllister <petr.mcallister@gmail.com>
Signed-off-by: Petr McAllister <petr.mcallister@gmail.com>
Signed-off-by: Petr McAllister <petr.mcallister@gmail.com>
Signed-off-by: Petr McAllister <petr.mcallister@gmail.com>
Signed-off-by: Petr McAllister <petr.mcallister@gmail.com>
Signed-off-by: Petr McAllister <petr.mcallister@gmail.com>
Signed-off-by: Petr McAllister <petr.mcallister@gmail.com>
Signed-off-by: Petr McAllister <petr.mcallister@gmail.com>
Signed-off-by: Petr McAllister <petr.mcallister@gmail.com>
…space Signed-off-by: Petr McAllister <petr.mcallister@solo.io>
Signed-off-by: Petr McAllister <petr.mcallister@solo.io>
…space Signed-off-by: Petr McAllister <petr.mcallister@solo.io>
Signed-off-by: Petr McAllister <petr.mcallister@solo.io>
Signed-off-by: Petr McAllister <petr.mcallister@solo.io>
Signed-off-by: Petr McAllister <petr.mcallister@solo.io>
Signed-off-by: Petr McAllister <petr.mcallister@solo.io>
Signed-off-by: Petr McAllister <petr.mcallister@solo.io>
DiscoverySelectors
conflict
@PetrMc Thankyou for such a quick turnaround. We did a revert so your changes from last week is missing in the PR. Please sync your fork and then push the changes. |
Signed-off-by: Petr McAllister <petr.mcallister@solo.io>
Signed-off-by: Petr McAllister <petr.mcallister@solo.io>
sorry missed it. Should be good to go now. |
Thankyou @PetrMc We will validate this soon! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PetrMc Could you make this change?
Signed-off-by: Petr McAllister <petr.mcallister@solo.io>
@elamaran11 @zirain - the requested change is applied, please let me know if anything else is needed. |
Thankyou @PetrMc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @PetrMc for the quick updates on this! Everything is working as expected and both PR's are co-existing on the cluster with that new edit applied. LGTM
EKSA:
- VMware (K8s 1.28, Bottlerocket 1.15): Pods deploy and reach a ready state, tester completes successfully on first attempt
- Outposts (K8s 1.27, Amazon Linux 2): Pods deploy and reach a ready state, tester completes successfully on first attempt
- Baremetal (K8s 1.27, Ubuntu 20.04.6 LTS): Pods deploy and reach a ready state, tester completes successfully on first attempt
EKS:
- EKS (K8s 1.28, ARM Bottlerocket 1.19): Pods deploy and reach a ready state, tester completes successfully on first attempt
- EKS (K8s 1.28, ARM Amazon Linux 2): Pods deploy and reach a ready state, tester completes successfully on first attempt
- EKS (K8s 1.28, x86 Amazon Linux 2): Pods deploy and reach a ready state, tester completes successfully on first attempt
- EKS (K8s 1.28, x86 Bottlerocket): Pods deploy and reach a ready state, tester completes successfully on first attempt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Looks like your deployment
|
@elamaran11 / @mikemcd3912 is there any action that are required on my end? |
@PetrMc Thankyou so much for fast action on this and thankyou so much for following back. We are good with this now. We now have both istio based meshes working fine on our EKS and EKS-A clusters. Please check with your team and send us an email or slack if you are interested to do a joint blog on this when you also have the paid product submitted as a PR. Looking forward for your submission of Paid product as a PR and also looking forward to working with you more. |
…suecomment-2083122552
Issue #, if available:
Description of changes:
Added "DiscoverySelectors"
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.