Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address DiscoverySelectors conflict #261

Merged
merged 22 commits into from
May 2, 2024

Conversation

PetrMc
Copy link
Contributor

@PetrMc PetrMc commented Apr 29, 2024

…suecomment-2083122552

Issue #, if available:

Description of changes:

Added "DiscoverySelectors"

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

PetrMc and others added 18 commits November 2, 2023 21:56
Signed-off-by: Petr McAllister <petr.mcallister@gmail.com>
Signed-off-by: Petr McAllister <petr.mcallister@gmail.com>
Signed-off-by: Petr McAllister <petr.mcallister@gmail.com>
Signed-off-by: Petr McAllister <petr.mcallister@gmail.com>
Signed-off-by: Petr McAllister <petr.mcallister@gmail.com>
Signed-off-by: Petr McAllister <petr.mcallister@gmail.com>
Signed-off-by: Petr McAllister <petr.mcallister@gmail.com>
Signed-off-by: Petr McAllister <petr.mcallister@gmail.com>
Signed-off-by: Petr McAllister <petr.mcallister@gmail.com>
…space

Signed-off-by: Petr McAllister <petr.mcallister@solo.io>
Signed-off-by: Petr McAllister <petr.mcallister@solo.io>
…space

Signed-off-by: Petr McAllister <petr.mcallister@solo.io>
Signed-off-by: Petr McAllister <petr.mcallister@solo.io>
Signed-off-by: Petr McAllister <petr.mcallister@solo.io>
Signed-off-by: Petr McAllister <petr.mcallister@solo.io>
Signed-off-by: Petr McAllister <petr.mcallister@solo.io>
Signed-off-by: Petr McAllister <petr.mcallister@solo.io>
@PetrMc PetrMc changed the title Address https://github.com/aws-samples/eks-anywhere-addons/pull/255#is… Address DiscoverySelectors conflict Apr 29, 2024
@PetrMc PetrMc changed the title Address DiscoverySelectors conflict Address DiscoverySelectors conflict Apr 29, 2024
@elamaran11
Copy link
Contributor

@PetrMc Thankyou for such a quick turnaround. We did a revert so your changes from last week is missing in the PR. Please sync your fork and then push the changes.

Petr McAllister added 3 commits April 29, 2024 11:08
Signed-off-by: Petr McAllister <petr.mcallister@solo.io>
Signed-off-by: Petr McAllister <petr.mcallister@solo.io>
@PetrMc
Copy link
Contributor Author

PetrMc commented Apr 29, 2024

sorry missed it. Should be good to go now.

@elamaran11
Copy link
Contributor

Thankyou @PetrMc We will validate this soon!

Copy link
Contributor

@elamaran11 elamaran11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PetrMc Could you make this change?

Signed-off-by: Petr McAllister <petr.mcallister@solo.io>
@PetrMc
Copy link
Contributor Author

PetrMc commented May 2, 2024

@elamaran11 @zirain - the requested change is applied, please let me know if anything else is needed.

@elamaran11
Copy link
Contributor

@elamaran11 @zirain - the requested change is applied, please let me know if anything else is needed.

Thankyou @PetrMc

Copy link
Contributor

@mikemcd3912 mikemcd3912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @PetrMc for the quick updates on this! Everything is working as expected and both PR's are co-existing on the cluster with that new edit applied. LGTM

EKSA:

  • VMware (K8s 1.28, Bottlerocket 1.15): Pods deploy and reach a ready state, tester completes successfully on first attempt
  • Outposts (K8s 1.27, Amazon Linux 2): Pods deploy and reach a ready state, tester completes successfully on first attempt
  • Baremetal (K8s 1.27, Ubuntu 20.04.6 LTS): Pods deploy and reach a ready state, tester completes successfully on first attempt

EKS:

  • EKS (K8s 1.28, ARM Bottlerocket 1.19): Pods deploy and reach a ready state, tester completes successfully on first attempt
  • EKS (K8s 1.28, ARM Amazon Linux 2): Pods deploy and reach a ready state, tester completes successfully on first attempt
  • EKS (K8s 1.28, x86 Amazon Linux 2): Pods deploy and reach a ready state, tester completes successfully on first attempt
  • EKS (K8s 1.28, x86 Bottlerocket): Pods deploy and reach a ready state, tester completes successfully on first attempt

Copy link
Contributor

@elamaran11 elamaran11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikemcd3912 mikemcd3912 merged commit 10774f2 into aws-samples:main May 2, 2024
1 check passed
@elamaran11
Copy link
Contributor

Looks like your deployment istiod-1-18-3-solo is failing.
Specifically, it looks like these pods are failing:

  • Pod: istiod-1-18-3-solo-5f996795d8-czvmd.

@PetrMc
Copy link
Contributor Author

PetrMc commented May 6, 2024

@elamaran11 / @mikemcd3912 is there any action that are required on my end?

@elamaran11
Copy link
Contributor

elamaran11 commented May 6, 2024

@PetrMc Thankyou so much for fast action on this and thankyou so much for following back. We are good with this now. We now have both istio based meshes working fine on our EKS and EKS-A clusters. Please check with your team and send us an email or slack if you are interested to do a joint blog on this when you also have the paid product submitted as a PR. Looking forward for your submission of Paid product as a PR and also looking forward to working with you more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants