-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Vault version #294
Update Vault version #294
Conversation
Hi @gautambaghel , Thanks for the update PR! I'd like to make a request prior to merging - Since Vault was onboarded we have made updates to our functional testing requirements outlined here in which we'll need the tester to be implemented as a CronJob and set up to run once daily so that we can perform ongoing monitoring of the solution's stability and identify any issues quickly if they were to arise. An example of what we are looking for can be found here The functional tests that are being run look like they're in line with our updated requirements, so all we'll need is that Job converted into a CronJob and have it produce a successful test result across the environments before I can merge the PR |
Hey @mikemcd3912 - that's fair, I'll track this request however, I won't be able to implement it until later due to other commitments. If you require the PR list to be clean, feel free to close this out I'll open it again. |
@gautambaghel We can currently use the version updates. But please get us a new PR asap for CJ. @mikemcd3912 Lets test and merge this. |
Looks like your deployment
|
@elamaran11 - what is the error exactly? can I get the logs? |
@gautambaghel Statefulsets are not deploying on Hybrid nodes due to failing readiness probe. @mikemcd3912 Please share the logs from our environment to Gautham |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pods deploy and reach a ready state, testers complete successfully - LGTM
@gautambaghel I was able to get my issue figured out on Hybrid Nodes, and the updated version looks good on our other platforms so no action needed! Thanks for checking in to offer troubleshooting assistance |
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.