Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
pipx
, a PyPA supported way to install executables in an isolated virtual environment.It is likely that this method obsoletes the scripts in this repository.
Contributor suggestion
As mentioned in section 5.5:
https://github.com/aws/aws-elastic-beanstalk-cli-setup/blob/6b2d6646c728e9ccfc6bb482926bb6ba5451c322/README.md#55-are-there-dependency-problems-that-this-mode-of-installation-doesnt-solve
It is possible for the dependencies of awsebcli to conflict.
A suggestion I have is to use the
--pip-args
argument, to add a--constraint
to the dependencies installed.Example
constraints.txt
file:Example usage of constraints file located from github:
NOTE:
constraints.txt
from another repository, but if this approach is considered for this package it should exist within this repository.awsebcli
is updated, as its version contained in the constrained dependencies above. But we can simple omit entries we do not want constrained and only update other dependencies when there are breaking changes, e.g. lock packages that are not under AWS control and only bump their versions when it would conflict with the AWS ownedawsebcli
orbotocore
pakckages.Issue #, if available:
N/A
Agreement:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.