Add support for openssl PKCS#11 engine to openssl_posix.c #1780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Escape semicolons in config definitions that might be pkcs11 URIs.
paulbartell
force-pushed
the
paulbartell/openssl_libp11_support
branch
from
16841cc
to
73542a7
Compare
paulbartell
force-pushed
the
paulbartell/openssl_libp11_support
branch
from
73542a7
to
eb9bcfc
Compare
paulbartell
force-pushed
the
paulbartell/openssl_libp11_support
branch
from
ec02980
to
3813275
Compare
| ``` | ||
| p11tool --login --load-certificate=aws_iot_pk.crt --write --label=aws_iot_pk "pkcs11:token=default" | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Steps are missing or its not clear how to add/get Amazon Root CA or private rootCA from system trust store.
There was a problem hiding this comment.
They're automatically included by the OS.
There was a problem hiding this comment.
See https://p11-glue.github.io/p11-glue/p11-kit/manual/trust-module.html for more information.
I'll add a note similar to:
You can confirm this with the follow cli command:
p11tool --list-all-certs pkcs11:token=System%20Trust | grep Amazon\ Root\ CA
| assert( pSslContext != NULL ); | ||
| assert( pEngine != NULL ); | ||
| assert( pClientCertURI != NULL ); | ||
|
|
There was a problem hiding this comment.
Add debug log for pClientCertURI here ?
| if( pOpensslCredentials->pRootCaPath != NULL ) | ||
| /* Initialize the pkcs11 engine if needed */ | ||
| if( ( pOpensslCredentials->pPrivateKeyPath != NULL ) && | ||
| ( pOpensslCredentials->pClientCertPath != NULL ) ) |
There was a problem hiding this comment.
Check for pOpensslCredentials->pRootCaPath != NULL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the libp11 openssl engine and p11-kit to the openssl_posix.c transport interface implementation.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.