Collect node logs after --up, --down phases #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartermckinnon
force-pushed
the
collect-node-logs
branch
from
60c174b
to
031e9d0
Compare
cartermckinnon
force-pushed
the
collect-node-logs
branch
2 times, most recently
from
5a33663
to
cd8ff3a
Compare
cartermckinnon
force-pushed
the
collect-node-logs
branch
from
cd8ff3a
to
18b1005
Compare
cartermckinnon
changed the title
cartermckinnon
changed the title
Issacwww
approved these changes
Oct 15, 2024
ndbaker1
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This adds optional node log collection after the Up() and Down() phases of the deployer. If the
--log-bucketflag is passed, an SSM document will be used to execute the/etc/eks/log-collector/eks-log-collector.shscript that is included in Amazon Linux based EKS AMIs. The resulting tarball is uploaded to the S3 bucket, with its key including the run ID + phase.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.