Skip to content

Commit

Permalink
ci: don't remove cluster with unhealthy mng (#5746)
Browse files Browse the repository at this point in the history
  • Loading branch information
jmdeal authored Mar 1, 2024
1 parent 88b9c07 commit 4b1d4e6
Showing 1 changed file with 13 additions and 1 deletion.
14 changes: 13 additions & 1 deletion .github/workflows/e2e.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -172,9 +172,21 @@ jobs:
role: ${{ vars.CI_ROLE_NAME }}
region: ${{ inputs.region }}
cluster_name: ${{ steps.generate-cluster-name.outputs.CLUSTER_NAME }}
# In the case of failure, check if the managed node group is unhealthy. If so, do not clean up cluster for further investigation.
# TODO: @jmdeal remove after investigation is complete
- name: detect unhealthy mng
id: detect-unhealthy-mng
shell: bash
if: failure() || cancelled()
run: |
if ! kubectl get nodes -l eks.amazonaws.com/nodegroup -oyaml | yq ".items[].status.conditions" | grep -q "KubeletNotReady"; then
echo UNHEALTHY="false" >> "$GITHUB_OUTPUT"
else
echo UNHEALTHY="true" >> "$GITHUB_OUTPUT"
fi
- name: cleanup karpenter and cluster '${{ steps.generate-cluster-name.outputs.CLUSTER_NAME }}' resources
uses: ./.github/actions/e2e/cleanup
if: always() && inputs.cleanup
if: always() && inputs.cleanup && (steps.detect-unhealthy-mng.conclusion == 'skipped' || steps.detect-unhealthy-mng.outputs.UNHEALTHY == 'false')
with:
account_id: ${{ vars.CI_ACCOUNT_ID }}
role: ${{ vars.CI_ROLE_NAME }}
Expand Down

0 comments on commit 4b1d4e6

Please sign in to comment.