Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error for KubeletConfiguration that isn't supported for an AMIFamily #3722

Open
jonathan-innis opened this issue Apr 7, 2023 · 5 comments
Open
Labels
chore Issues that are refactors or code cleanup tasks good-first-issue Good for newcomers v1 Issues requiring resolution by the v1 milestone

Comments

@jonathan-innis
Copy link
Contributor

Tell us about your request

There are some pieces of the v1alpha5.KubeletConfiguration that aren't supported by Bottlerocket AMIFamily. Rather than silently ignoring these pieces, we should error to the user that we can't launch when there are pieces of the kubeletConfiguration that aren't supported by the AMIFamily

Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?

N/A

Are you currently working around this issue?

Silently ignoring v1alpha5.KubeletConfiguration that isn't supported by the AMIFamily

Additional Context

No response

Attachments

No response

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@jonathan-innis jonathan-innis added chore Issues that are refactors or code cleanup tasks v1 Issues requiring resolution by the v1 milestone labels Apr 7, 2023
@jonathan-innis jonathan-innis changed the title Error for KubeletConfiguration that isn's supported for an AMIFamily Error for KubeletConfiguration that isn't supported for an AMIFamily Apr 7, 2023
@jonathan-innis jonathan-innis added the good-first-issue Good for newcomers label Apr 7, 2023
masturd pushed a commit to masturd/karpenter that referenced this issue Apr 8, 2023
fix to add Error for KubeletConfiguration that isnt suported for
AMIFamily
Fixes aws/karpenter/aws#3722
@jonathan-innis
Copy link
Contributor Author

Currently, the fields that aren't supported by Bottlerocket but are supported by the Karpenter kubeletConfiguration are:

  1. evictionSoft
  2. podsPerCore
  3. cpuCFSQuota

@srinchow
Copy link

@jonathan-innis i can take this up if this needs to be done

@stmcginnis
Copy link

Small update on the unsupported fields listed above.

settings.kubernetes.cpu-cfs-quota-enforced and settings.kubernetes.eviction-soft* settings are available as of Bottlerocket 1.14.0 and later. 1.14.0 was released in May 11, so hopefully any new deployments would be using a release that includes these settings.

@ecerulm
Copy link
Contributor

ecerulm commented Aug 16, 2024

Related: Add Bottlerocket support for kubeletConfiguration.evictionSoft #4271
Related: chore: add bottlerocket support for kubeletconfiguration evictionsoft #6760
Related: chore: Add soft eviction setting to Bottlerocket kublet config #6390

@diranged
Copy link

Agreed btw ... I spent a few hours last night trying to understand why settings were not being applied, until I went digging through the code. Thanks for beginning work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issues that are refactors or code cleanup tasks good-first-issue Good for newcomers v1 Issues requiring resolution by the v1 milestone
Projects
None yet
Development

No branches or pull requests

5 participants