Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bottlerocket support for kubeletConfiguration.cpuCFSQuota #6782

Closed
ecerulm opened this issue Aug 16, 2024 · 3 comments · Fixed by #6794
Closed

Add Bottlerocket support for kubeletConfiguration.cpuCFSQuota #6782

ecerulm opened this issue Aug 16, 2024 · 3 comments · Fixed by #6794
Labels
feature New feature or request needs-triage Issues that need to be triaged

Comments

@ecerulm
Copy link
Contributor

ecerulm commented Aug 16, 2024

Description

What problem are you trying to solve?

Bottlerocket AMI now support CPU quota enforcement settings.kubernetes.cpu-fs-quota-enforced (see bottlerocket-os/bottlerocket#2930) . We should pass these additinal properties from the kubeletConfiguration into the TOML.

How important is this feature to you?

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@ecerulm ecerulm added feature New feature or request needs-triage Issues that need to be triaged labels Aug 16, 2024
@jigisha620
Copy link
Contributor

Hi @ecerulm,
This is already being supported kubeletConfiguration.cpuCFSQuota.

@ecerulm
Copy link
Contributor Author

ecerulm commented Aug 18, 2024

@jigisha620 , the documentation at https://karpenter.sh/docs/concepts/nodeclasses/ explicitly say

Warning:
The Bottlerocket AMIFamily does not support the following fields:

evictionSoft
evictionSoftGracePeriod
evictionMaxPodGracePeriod
cpuCFSQuota

If any of these fields are specified on a Bottlerocket EC2NodeClass, they will be ommited from generated UserData and ignored for scheduling purposes. Support for these fields can be tracked via GitHub issue #3722.

image

That section of the documentation was added 4 days ago on #6720, if it's not accurate and kubeletConfiguration.cpuCFSQuota is actually supported in (1.0.0) then we should change the documentation. If it's not yet supported in 1.0.0 but it's supported in "main" then perfect and you can close this issue.

In any case this is related to #4271 and #3722

@jigisha620
Copy link
Contributor

@ecerulm , thanks for pointing this out. I will go ahead and update the documentation since the change to support this field was merged - #4260

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request needs-triage Issues that need to be triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants