Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bottlerocket support for kubeletConfiguration.evictionSoft #4271

Open
jonathan-innis opened this issue Jul 14, 2023 · 4 comments
Open

Add Bottlerocket support for kubeletConfiguration.evictionSoft #4271

jonathan-innis opened this issue Jul 14, 2023 · 4 comments
Labels
feature New feature or request good-first-issue Good for newcomers

Comments

@jonathan-innis
Copy link
Contributor

Description

What problem are you trying to solve?

Bottlerocket AMIs now support EvictionSoft in the latest versions. We should pass in these additional properties from the kubeletConfiguration into the TOML

PR: bottlerocket-os/bottlerocket#2930

How important is this feature to you?

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@jonathan-innis jonathan-innis added the feature New feature or request label Jul 14, 2023
@jonathan-innis jonathan-innis changed the title Add Bottlerocket support for EvictionSoft Add Bottlerocket support for kubeletConfiguration.evictionSoft Jul 14, 2023
@jonathan-innis jonathan-innis added the good-first-issue Good for newcomers label Jul 20, 2023
@sktech730
Copy link

@jonathan-innis I would like to contribute on this Issue and I am new to open source contributions please let me if there are any other details which need to know before I start working on this.

@ellistarn
Copy link
Contributor

@ecerulm
Copy link
Contributor

ecerulm commented Aug 16, 2024

Related: chore: Add soft eviction setting to Bottlerocket kublet config #6390

@ecerulm
Copy link
Contributor

ecerulm commented Aug 16, 2024

Bottlerocket also supports cpuCFSQuota so that should be supported by karpenter too, I've created #6782 to track that specifically but probably both could be implemented in the same PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request good-first-issue Good for newcomers
Projects
None yet
4 participants