perf: Reduce Memory Usage from the InstanceType Provider #5318

engedaam · 2023-12-13T18:00:29Z

Fixes #5196, #5225

Description

Clearing out the cache for the instance types provider on expired items.
Save items based on the EC2NodeClass resolution instead of EC2Nodeclass UUID

E2E Integration Periodic Run
Memory Utilization

CPU Utilization

E2E Integration with PR Run
Memory Utilization

CPU Utilization

E2E integration was used comparing the memory usage

How was this change tested?

/karpenter snapshot

Does this change impact docs?

Yes, PR includes docs updates
Yes, issue opened: #
No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

netlify · 2023-12-13T18:00:38Z

✅ Deploy Preview for karpenter-docs-prod canceled.

Name	Link
🔨 Latest commit	`72a42ef`
🔍 Latest deploy log	https://app.netlify.com/sites/karpenter-docs-prod/deploys/657baa7f5d903a00088ea020

engedaam

/karpenter snapshot

coveralls · 2023-12-13T18:02:45Z

Pull Request Test Coverage Report for Build 7216708555

9 of 9 (100.0%) changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.005%) to 82.536%

Files with Coverage Reduction	New Missed Lines	%
pkg/providers/amifamily/ami.go	1	90.32%

Totals
Change from base Build 7216670424:	-0.005%
Covered Lines:	4953
Relevant Lines:	6001

💛 - Coveralls

github-actions · 2023-12-13T18:06:16Z

Snapshot successfully published to "oci://071440425669.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-ef9cec15ffd88b66770c3c63c624d02c1f1a4e82".

engedaam

/karpenter scale

github-actions · 2023-12-13T18:18:35Z

Snapshot successfully published to "oci://071440425669.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-ef9cec15ffd88b66770c3c63c624d02c1f1a4e82".

pkg/providers/instancetype/instancetype.go

engedaam

/karpenter snapshot

github-actions · 2023-12-13T22:32:41Z

Snapshot successfully published to "oci://071440425669.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-a6fec625dc1f11740de68a9e9e2cdf50e0087b7e".

engedaam

/karpenter snapshot

github-actions · 2023-12-14T01:11:00Z

Snapshot successfully published to "oci://071440425669.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-cb5c8e46c1abc48b876ae86d2dafd28f2393d2fe".

pkg/cache/cache.go

pkg/providers/instancetype/instancetype.go

engedaam

/karpenter snapshot

github-actions · 2023-12-14T02:12:46Z

Snapshot successfully published to "oci://071440425669.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-f9c7fc899d354582ac27c5b2b6f1997293e2fac0".

engedaam

/karpenter snapshot

github-actions · 2023-12-14T03:30:25Z

Snapshot successfully published to "oci://071440425669.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-f7582631b90095bd6ca53442e5a3d158182e8a42".

engedaam

/karpenter scale

github-actions · 2023-12-14T06:16:37Z

Snapshot successfully published to "oci://071440425669.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-f7582631b90095bd6ca53442e5a3d158182e8a42".

engedaam

/karpenter snapshot

github-actions · 2023-12-15T00:21:00Z

Snapshot successfully published to "oci://021119463062.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-46bb857a831bcfa75694f396e1c7b1e430f62583".

engedaam

/karpenter snapshot

github-actions · 2023-12-15T00:29:09Z

Snapshot successfully published to "oci://021119463062.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-ce36bc4fae732e652970eccbcec160aa8d04b43d".

jonathan-innis

Looks good. Just a couple of questions

pkg/providers/instancetype/instancetype.go

pkg/cache/cache.go

engedaam

/karpenter snapshot

github-actions · 2023-12-15T01:01:17Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-2a86404dfb10aa06881e6f46e656dd3565d2c454.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

engedaam

/karpenter snapshot

github-actions · 2023-12-15T01:27:04Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-72a42ef401108e7ef9760ca36d694bdd217ba017.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

engedaam

/karpenter scale

jonathan-innis

This all seems good to me. If we are confident that this cleanup interval isn't going to tangibly hurt our performance and improve our memory footprint, then 🚀

engedaam requested a review from a team as a code owner December 13, 2023 18:00

engedaam requested a review from jonathan-innis December 13, 2023 18:00

engedaam changed the title ~~fix: Memory increase~~ perf: Reduce Memory Usage from the InstanceType Provider Dec 13, 2023

engedaam force-pushed the fix-memory-incress branch from 80b760b to ef9cec1 Compare December 13, 2023 18:02

engedaam commented Dec 13, 2023

View reviewed changes

jonathan-innis reviewed Dec 13, 2023

View reviewed changes

pkg/providers/instancetype/instancetype.go Outdated Show resolved Hide resolved

engedaam force-pushed the fix-memory-incress branch 2 times, most recently from eb3b1e7 to a6fec62 Compare December 13, 2023 22:20

engedaam commented Dec 13, 2023

View reviewed changes

engedaam force-pushed the fix-memory-incress branch 2 times, most recently from 9a834cf to 9fc32f2 Compare December 14, 2023 00:14

engedaam commented Dec 14, 2023

View reviewed changes

jonathan-innis reviewed Dec 14, 2023

View reviewed changes

engedaam force-pushed the fix-memory-incress branch 3 times, most recently from e32a06c to f9c7fc8 Compare December 14, 2023 02:08

engedaam commented Dec 14, 2023

View reviewed changes

engedaam force-pushed the fix-memory-incress branch 4 times, most recently from 5504e8f to f758263 Compare December 14, 2023 03:23

engedaam commented Dec 14, 2023

View reviewed changes

engedaam force-pushed the fix-memory-incress branch 2 times, most recently from 2322881 to 46bb857 Compare December 15, 2023 00:16

engedaam commented Dec 15, 2023

View reviewed changes

engedaam force-pushed the fix-memory-incress branch from 46bb857 to ce36bc4 Compare December 15, 2023 00:24

engedaam commented Dec 15, 2023

View reviewed changes

jonathan-innis reviewed Dec 15, 2023

View reviewed changes

pkg/providers/instancetype/instancetype.go Outdated Show resolved Hide resolved

pkg/cache/cache.go Outdated Show resolved Hide resolved

engedaam force-pushed the fix-memory-incress branch 2 times, most recently from d2eaceb to 2a86404 Compare December 15, 2023 00:56

engedaam commented Dec 15, 2023

View reviewed changes

Fix increase

72a42ef

engedaam force-pushed the fix-memory-incress branch from 2a86404 to 72a42ef Compare December 15, 2023 01:23

engedaam commented Dec 15, 2023

View reviewed changes

jonathan-innis approved these changes Dec 15, 2023

View reviewed changes

engedaam merged commit d71bcd8 into aws:main Dec 15, 2023
27 of 28 checks passed

engedaam deleted the fix-memory-incress branch December 15, 2023 14:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

perf: Reduce Memory Usage from the InstanceType Provider #5318

perf: Reduce Memory Usage from the InstanceType Provider #5318

engedaam commented Dec 13, 2023 •

edited

Loading

netlify bot commented Dec 13, 2023 •

edited

Loading

engedaam left a comment

coveralls commented Dec 13, 2023 •

edited

Loading

github-actions bot commented Dec 13, 2023

engedaam left a comment

github-actions bot commented Dec 13, 2023

engedaam left a comment

github-actions bot commented Dec 13, 2023

engedaam left a comment

github-actions bot commented Dec 14, 2023

engedaam left a comment

github-actions bot commented Dec 14, 2023

engedaam left a comment

github-actions bot commented Dec 14, 2023

engedaam left a comment

github-actions bot commented Dec 14, 2023

engedaam left a comment

github-actions bot commented Dec 15, 2023

engedaam left a comment

github-actions bot commented Dec 15, 2023

jonathan-innis left a comment

engedaam left a comment

github-actions bot commented Dec 15, 2023

engedaam left a comment

github-actions bot commented Dec 15, 2023

engedaam left a comment

jonathan-innis left a comment

perf: Reduce Memory Usage from the InstanceType Provider #5318

perf: Reduce Memory Usage from the InstanceType Provider #5318

Conversation

engedaam commented Dec 13, 2023 • edited Loading

netlify bot commented Dec 13, 2023 • edited Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

engedaam left a comment

Choose a reason for hiding this comment

coveralls commented Dec 13, 2023 • edited Loading

Pull Request Test Coverage Report for Build 7216708555

💛 - Coveralls

github-actions bot commented Dec 13, 2023

engedaam left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 13, 2023

engedaam left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 13, 2023

engedaam left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 14, 2023

engedaam left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 14, 2023

engedaam left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 14, 2023

engedaam left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 14, 2023

engedaam left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 15, 2023

engedaam left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 15, 2023

jonathan-innis left a comment

Choose a reason for hiding this comment

engedaam left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 15, 2023

engedaam left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 15, 2023

engedaam left a comment

Choose a reason for hiding this comment

jonathan-innis left a comment

Choose a reason for hiding this comment

engedaam commented Dec 13, 2023 •

edited

Loading

netlify bot commented Dec 13, 2023 •

edited

Loading

coveralls commented Dec 13, 2023 •

edited

Loading