Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert website gomod change #5320

Merged
merged 2 commits into from
Dec 13, 2023
Merged

chore: revert website gomod change #5320

merged 2 commits into from
Dec 13, 2023

Conversation

njtran
Copy link
Contributor

@njtran njtran commented Dec 13, 2023

Fixes #N/A

Description
reverting a change made to update the website go.mod that broke some things in the website

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@njtran njtran requested a review from a team as a code owner December 13, 2023 23:38
@njtran njtran requested a review from engedaam December 13, 2023 23:38
Copy link

netlify bot commented Dec 13, 2023

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit aaf86cd
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/657a40bd3b249f00085de927
😎 Deploy Preview https://deploy-preview-5320--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@njtran njtran enabled auto-merge (squash) December 13, 2023 23:41
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7202406183

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 82.489%

Totals Coverage Status
Change from base Build 7200477367: 0.02%
Covered Lines: 4918
Relevant Lines: 5962

💛 - Coveralls

@njtran njtran merged commit f2c335e into aws:main Dec 13, 2023
15 checks passed
@dtzar
Copy link
Contributor

dtzar commented Dec 16, 2023

Yep - using the latest version of docsy is going to require fixing some things since the major update to bootstrap 5. See support doc on docsy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants