-
Notifications
You must be signed in to change notification settings - Fork 963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance AMI task docs after review #5749
Conversation
✅ Deploy Preview for karpenter-docs-prod ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Pull Request Test Coverage Report for Build 8113843942Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Looking good! A couple of small comments, I only left them on one of the copies, but they of course apply to both. I'm also wondering if we should include this in the v0.33 and v0.32 docs as well, just with a disclaimer in the disruption budgets task that users will need to upgrade to v0.34. Originally I was thinking we could maybe include it with Task 3 dropped but if anything including it gives users a good example of why they should upgrade. |
I totally agree with that. I've worked on docs projects where we only published one version, but noted when a feature was added when we described it for exactly the reason you mentioned. Can we merge this, then I can follow up with another PR to update and copy the content to v0.32 and v0.33? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, seems fine to take as a follow-up. LGTM 🚀
Description
Updated the Managing AMIs docs after a formal review.
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.