Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chart): Added cosign verify docs #5759

Merged
merged 2 commits into from
Mar 2, 2024

Conversation

stevehipwell
Copy link
Contributor

Fixes #N/A

Description
This PR adds documentation on how to use cosign to verify the Karpenter Helm chart.

How was this change tested?
By following the documentation along for the 0.35.0 Helm chart which has been signed.

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
@stevehipwell stevehipwell requested a review from a team as a code owner March 1, 2024 13:17
Copy link

netlify bot commented Mar 1, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit b827ee9
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/65e397f9657ec60008b18c5c
😎 Deploy Preview https://deploy-preview-5759--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stevehipwell
Copy link
Contributor Author

@jonathan-innis hopefully these are the docs that you requested?

jonathan-innis
jonathan-innis previously approved these changes Mar 1, 2024
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I think that this could also be useful in the v0.35.0 docs as well! Up to you if you think that we should update them now or can wait for the v0.36.0 release to put them out there

@coveralls
Copy link

coveralls commented Mar 1, 2024

Pull Request Test Coverage Report for Build 8125498222

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.626%

Totals Coverage Status
Change from base Build 8122695235: 0.0%
Covered Lines: 5255
Relevant Lines: 6360

💛 - Coveralls

@stevehipwell
Copy link
Contributor Author

@jonathan-innis I'm not sure I'd worry about getting this into the docs outside of a general release.

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit ab96997 into aws:main Mar 2, 2024
17 checks passed
@stevehipwell stevehipwell deleted the chart-cosign-verify-docs branch March 5, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants