Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add InstanceStorePolicy to instance list cache #5763

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

jmdeal
Copy link
Contributor

@jmdeal jmdeal commented Mar 1, 2024

Fixes #5756

Description

How was this change tested?

  • manually
  • functional tests

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmdeal jmdeal requested a review from a team as a code owner March 1, 2024 20:47
@jmdeal jmdeal requested a review from njtran March 1, 2024 20:47
Copy link

netlify bot commented Mar 1, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit df4b077
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/65e23ec9ad47760008bc4417
😎 Deploy Preview https://deploy-preview-5763--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8117019073

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.642%

Totals Coverage Status
Change from base Build 8114753237: 0.0%
Covered Lines: 5256
Relevant Lines: 6360

💛 - Coveralls

@jmdeal
Copy link
Contributor Author

jmdeal commented Mar 1, 2024

Going to take up more functional testing as a follow-up.

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jmdeal jmdeal merged commit 88b9c07 into aws:main Mar 1, 2024
17 checks passed
jmdeal added a commit to jmdeal/karpenter-provider-aws that referenced this pull request Mar 1, 2024
njtran pushed a commit to njtran/karpenter-provider-aws that referenced this pull request Mar 7, 2024
@jmdeal jmdeal deleted the fix-cache-instance-list branch May 9, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instance Type Caching Results in Incorrect EphemeralStorage
3 participants