Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add cluster exclusion list to cleanup #5764

Merged
merged 2 commits into from
Mar 2, 2024
Merged

Conversation

jmdeal
Copy link
Contributor

@jmdeal jmdeal commented Mar 1, 2024

Fixes #N/A

Description
Adds an exclusion list to our cleanup script to keep clusters around for investigation purposes. Motivated by ongoing SQS failures in our soak tests.

How was this change tested?
N/A

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmdeal jmdeal requested a review from a team as a code owner March 1, 2024 21:37
@jmdeal jmdeal requested a review from tzneal March 1, 2024 21:37
Copy link

netlify bot commented Mar 1, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 9d88ee8
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/65e266960e4b5e00097f2b6c

@coveralls
Copy link

coveralls commented Mar 1, 2024

Pull Request Test Coverage Report for Build 8118419967

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 82.626%

Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 90.32%
Totals Coverage Status
Change from base Build 8114753237: -0.02%
Covered Lines: 5255
Relevant Lines: 6360

💛 - Coveralls

jonathan-innis
jonathan-innis previously approved these changes Mar 1, 2024
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

test/hack/resource/clean/main.go Show resolved Hide resolved
test/hack/resource/clean/main.go Show resolved Hide resolved
jonathan-innis
jonathan-innis previously approved these changes Mar 1, 2024
Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jmdeal jmdeal merged commit e53c52b into aws:main Mar 2, 2024
16 checks passed
@jmdeal jmdeal deleted the save-soak-cluster branch May 9, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants