Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: change default node pool instance generation #6961

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

njtran
Copy link
Contributor

@njtran njtran commented Sep 9, 2024

Fixes #N/A

Description
Lower gen instance types are deprecated

How was this change tested?
testing here

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@njtran njtran requested a review from a team as a code owner September 9, 2024 21:25
@njtran njtran requested a review from jmdeal September 9, 2024 21:25
Copy link
Contributor Author

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link

netlify bot commented Sep 9, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit e9d882e
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66df67ce3ef2fc0009df1f25

Copy link
Contributor

github-actions bot commented Sep 9, 2024

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-e9d882ecb3fcac70a11d0dbe0d5656551c11f28c.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-e9d882ecb3fcac70a11d0dbe0d5656551c11f28c" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10781535740

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 83.04%

Totals Coverage Status
Change from base Build 10780523034: 0.02%
Covered Lines: 5513
Relevant Lines: 6639

💛 - Coveralls

Copy link
Contributor

This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants