-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Added new policy to PodDisruptionBudget #7037
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for karpenter-docs-prod ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this is only available in beta starting in 1.27. What happens with users who try to define this on 1.25/1.26? Is there some way we can just not include this based on the kubernetes version?
f5bff64
to
8257a6d
Compare
@njtran Good point, I've added a function that ensures it only adds the field if the Kubernetes version is >= 1.27. |
9458443
to
2db9c04
Compare
2db9c04
to
7df72fe
Compare
@@ -11,6 +11,11 @@ metadata: | |||
{{- end }} | |||
spec: | |||
maxUnavailable: {{ .Values.podDisruptionBudget.maxUnavailable }} | |||
{{- if (semverCompare ">= 1.27-0" .Capabilities.KubeVersion.Version) }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use .Capabilities.KubeVersion.Minor? Don't think we care too much about major or patch, right?
Fixes #7025
Description
Added the
unhealthyPodEvictionPolicy
to the Karpenter PDB.How was this change tested?
I generated a helm template file locally and tried to set
unhealthyPodEvictionPolicy
in the chart values toAlwaysAllow
:I also tried not setting anything in the chart values and expected that there would be no mention of
unhealthyPodEvictionPolicy
in the spec:Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.