Allow the scheduler to be updated #7045
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod canceled.
|
Pull Request Test Coverage Report for Build 10958923846Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
njtran
reviewed
Sep 30, 2024
|
This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity. |
stijndehaes
force-pushed
the
feature/allow-schedulername-update
branch
from
7af038c
to
a9fb4ee
Compare
|
@njtran can you give me another review? Sorry for taking so long to update my PR |
|
This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #N/A
Description
This change allows the scheduler for the karpenter pods to be changed.
This is usefull when using a custom scheduler, when mixing 2 different schedulers you might run into issues with priority and preemption (one scheduler deleting a pod to make room for Karpenter, but the other scheduler quickly schedules a new pod because there is room).
How was this change tested?
Copy of the helm chart applied locally
Does this change impact docs?
It updates the helm chart docs, but not the karpenter docs. They have been updated
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.