Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instance Profile V2 migration #7097

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

edibble21
Copy link

Fixes #N/A

Description
Migrated Instance Profile Provider V2 Migration and updated tests.

How was this change tested?
make presubmit
make test
make ci-test

Does this change impact docs?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@edibble21 edibble21 requested a review from a team as a code owner September 27, 2024 21:12
Copy link

netlify bot commented Sep 27, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 9954d74
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66fad2c1d288520008ec87e7

@coveralls
Copy link

coveralls commented Sep 27, 2024

Pull Request Test Coverage Report for Build 11110336608

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 58 of 133 (43.61%) changed or added relevant lines in 4 files are covered.
  • 76 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-0.5%) to 82.517%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/providers/instanceprofile/instanceprofile.go 17 20 85.0%
pkg/errors/errors.go 10 14 71.43%
pkg/operator/operator.go 0 13 0.0%
pkg/fake/iamapi.go 31 86 36.05%
Files with Coverage Reduction New Missed Lines %
pkg/test/environment.go 3 95.9%
pkg/errors/errors.go 4 55.56%
pkg/fake/iamapi.go 4 58.74%
pkg/providers/instancetype/instancetype.go 5 95.63%
pkg/providers/instancetype/types.go 8 97.91%
pkg/operator/operator.go 8 8.93%
pkg/cloudprovider/cloudprovider.go 44 73.88%
Totals Coverage Status
Change from base Build 11077084057: -0.5%
Covered Lines: 5593
Relevant Lines: 6778

💛 - Coveralls

Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 🚀

pkg/aws/sdk/sdk.go Outdated Show resolved Hide resolved
pkg/operator/operator.go Outdated Show resolved Hide resolved
pkg/operator/operator.go Outdated Show resolved Hide resolved
pkg/operator/operator.go Outdated Show resolved Hide resolved
pkg/operator/operator.go Outdated Show resolved Hide resolved
@edibble21 edibble21 force-pushed the V2Migration branch 2 times, most recently from 9e0aee3 to 6b069c1 Compare September 27, 2024 22:44
pkg/operator/operator.go Outdated Show resolved Hide resolved
pkg/operator/operator.go Outdated Show resolved Hide resolved
pkg/operator/operator.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants