chore: Add instance type resolver for creating instance types #7111

jonathan-innis · 2024-09-29T03:51:55Z

Fixes #N/A

Description

Add instancetype.Resolver to generate instance types in a single place

How was this change tested?

make presubmit
/karpenter snapshot

Does this change impact docs?

Yes, PR includes docs updates
Yes, issue opened: #
No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

netlify · 2024-09-29T03:52:19Z

✅ Deploy Preview for karpenter-docs-prod canceled.

Name	Link
🔨 Latest commit	`d1a7038`
🔍 Latest deploy log	https://app.netlify.com/sites/karpenter-docs-prod/deploys/66f9f62389f3a00008add378

coveralls · 2024-09-29T03:56:54Z

Pull Request Test Coverage Report for Build 11097421512

Details

133 of 141 (94.33%) changed or added relevant lines in 7 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 83.291%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/controllers/controllers.go	0	1	0.0%
pkg/operator/operator.go	0	1	0.0%
pkg/providers/instancetype/types.go	62	68	91.18%

Totals
Change from base Build 11077084057:	0.2%
Covered Lines:	5578
Relevant Lines:	6697

💛 - Coveralls

jonathan-innis

/karpenter snapshot

github-actions · 2024-09-29T04:11:37Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-adfe05f2e2b2a4b1634b5aa2066631b620452703.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-adfe05f2e2b2a4b1634b5aa2066631b620452703" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

jonathan-innis

/karpenter snapshot

jonathan-innis

/karpenter snapshot

jonathan-innis

/karpenter snapshot

github-actions · 2024-09-29T04:37:08Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-ecb969bedb444fd3a1c98b42f2fd4e4a86247546.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-ecb969bedb444fd3a1c98b42f2fd4e4a86247546" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

github-actions · 2024-09-29T04:38:24Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-4707e693c311ba0218bc17a097df073dee97ec3e.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-4707e693c311ba0218bc17a097df073dee97ec3e" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

jonathan-innis

/karpenter snapshot

github-actions · 2024-09-29T06:05:16Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-4d57869036af710d849e23130bf537ae23ef193d.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-4d57869036af710d849e23130bf537ae23ef193d" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

jonathan-innis

/karpenter snapshot

github-actions · 2024-09-29T21:51:59Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-027ed2416c5de40f9b0a94370dfb050625d415dc.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-027ed2416c5de40f9b0a94370dfb050625d415dc" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

cmd/controller/main.go

pkg/cloudprovider/cloudprovider.go

pkg/controllers/controllers.go

pkg/test/environment.go

pkg/providers/instancetype/instancetype.go

pkg/providers/instancetype/types.go

pkg/providers/instancetype/instancetype.go

jmdeal

LGTM 🚀

jonathan-innis commented Sep 29, 2024

View reviewed changes

jonathan-innis force-pushed the add-instance-type-generator branch from adfe05f to ecb969b Compare September 29, 2024 04:32

jonathan-innis commented Sep 29, 2024

View reviewed changes

jonathan-innis force-pushed the add-instance-type-generator branch from ecb969b to 4707e69 Compare September 29, 2024 04:34

jonathan-innis commented Sep 29, 2024

View reviewed changes

jonathan-innis force-pushed the add-instance-type-generator branch 3 times, most recently from cf411da to 4d57869 Compare September 29, 2024 05:29

jonathan-innis commented Sep 29, 2024

View reviewed changes

jonathan-innis force-pushed the add-instance-type-generator branch from 4d57869 to a4fbe41 Compare September 29, 2024 13:34

jonathan-innis changed the title ~~chore: Add instance type generator for creating instance types~~ chore: Add instance type resolver for creating instance types Sep 29, 2024

jonathan-innis force-pushed the add-instance-type-generator branch 5 times, most recently from f34a5ef to 0f5e403 Compare September 29, 2024 21:39

jonathan-innis marked this pull request as ready for review September 29, 2024 21:40

jonathan-innis requested a review from a team as a code owner September 29, 2024 21:40

jonathan-innis requested a review from bwagner5 September 29, 2024 21:40

Add instance type and instance type offering generator

027ed24

jonathan-innis force-pushed the add-instance-type-generator branch from 0f5e403 to 027ed24 Compare September 29, 2024 21:48

jonathan-innis commented Sep 29, 2024

View reviewed changes

jmdeal reviewed Sep 29, 2024

View reviewed changes

PR comments

d1a7038

jmdeal approved these changes Sep 30, 2024

View reviewed changes

jonathan-innis merged commit d91930e into aws:main Sep 30, 2024
16 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Add instance type resolver for creating instance types #7111

chore: Add instance type resolver for creating instance types #7111

jonathan-innis commented Sep 29, 2024 •

edited

Loading

netlify bot commented Sep 29, 2024 •

edited

Loading

coveralls commented Sep 29, 2024 •

edited

Loading

jonathan-innis left a comment

github-actions bot commented Sep 29, 2024

jonathan-innis left a comment

jonathan-innis left a comment

jonathan-innis left a comment

github-actions bot commented Sep 29, 2024

github-actions bot commented Sep 29, 2024

jonathan-innis left a comment

github-actions bot commented Sep 29, 2024

jonathan-innis left a comment

github-actions bot commented Sep 29, 2024

jmdeal left a comment

chore: Add instance type resolver for creating instance types #7111

chore: Add instance type resolver for creating instance types #7111

Conversation

jonathan-innis commented Sep 29, 2024 • edited Loading

netlify bot commented Sep 29, 2024 • edited Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

coveralls commented Sep 29, 2024 • edited Loading

Pull Request Test Coverage Report for Build 11097421512

Details

💛 - Coveralls

jonathan-innis left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 29, 2024

jonathan-innis left a comment

Choose a reason for hiding this comment

jonathan-innis left a comment

Choose a reason for hiding this comment

jonathan-innis left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 29, 2024

github-actions bot commented Sep 29, 2024

jonathan-innis left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 29, 2024

jonathan-innis left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 29, 2024

jmdeal left a comment

Choose a reason for hiding this comment

jonathan-innis commented Sep 29, 2024 •

edited

Loading

netlify bot commented Sep 29, 2024 •

edited

Loading

coveralls commented Sep 29, 2024 •

edited

Loading