Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable migration controllers if webhooks are enabled #7128

Merged
merged 9 commits into from
Sep 30, 2024

Conversation

rschalo
Copy link
Contributor

@rschalo rschalo commented Sep 30, 2024

Fixes #N/A

Description
Fixes caches failing to sync on latest patch when webhooks are disabled by not starting migration controllers when webhooks are disabled. This also moves crd/status patch to a conditional block and scopes crd update to only Karpenter CRDs.

How was this change tested?
make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@coveralls
Copy link

coveralls commented Sep 30, 2024

Pull Request Test Coverage Report for Build 11114646806

Details

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 79.36%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/controllers.go 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/fake/utils.go 2 94.56%
Totals Coverage Status
Change from base Build 11079084588: -0.04%
Covered Lines: 5956
Relevant Lines: 7505

💛 - Coveralls

@rschalo rschalo marked this pull request as ready for review September 30, 2024 19:34
@rschalo rschalo requested a review from a team as a code owner September 30, 2024 19:34
@rschalo rschalo requested a review from njtran September 30, 2024 19:34
@rschalo rschalo enabled auto-merge (squash) September 30, 2024 22:30
Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@rschalo rschalo merged commit 1552084 into aws:release-v1.0.x Sep 30, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants