Chore: version log change #7401
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod canceled.
|
Pull Request Test Coverage Report for Build 11898232051Details
💛 - Coveralls |
engedaam
reviewed
Nov 18, 2024
engedaam
previously approved these changes
Nov 18, 2024
jonathan-innis
requested changes
Nov 18, 2024
| } | ||
| } else if lo.FromPtr(output.Cluster.Version) != "" { | ||
| version = *output.Cluster.Version | ||
| log.FromContext(ctx).Info("retrieved Kubernetes version from EKS DescribeCluster", "version", version) | ||
| versionSource = "EKS DescribeCluster" | ||
| } else { | ||
| return "", fmt.Errorf("unable to retrieve Kubernetes version from EKS DescribeCluster") | ||
| } | ||
| p.cache.SetDefault(kubernetesVersionCacheKey, version) | ||
| if p.cm.HasChanged("kubernetes-version", version) { |
There was a problem hiding this comment.
If our version source changes, should we also add a log here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #N/A
Description
Made Version provider less noisy by changing logs
How was this change tested?
make presubmit
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.