-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up pre-commit hooks and workflows to check code style #313
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should run all the unit tests (tests/test_main.py etc.) to make sure none of the functionality is impacted. And probably run a build/test/push as well.
Once this is merged, can you also rebase 2.0.0-beta with these changes? |
Executed the local build/test and got the following results:
The failed tests exactly match what is documented in #316, so we can conclude that this PR doesn't introduce any new test failure. |
Sure I'll make sure to do it once this PR is merged |
Issue #, if available:
Currently the code base doesn't have any code stile check machnism.
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.