Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EKS logs collector script kube-proxy IPVS information scrape #1795

Merged
merged 6 commits into from
Oct 18, 2024

Conversation

AbeOwlu
Copy link
Contributor

@AbeOwlu AbeOwlu commented May 10, 2024

Issue #, if available: #1790

Description of changes:
Adding;

  • check for IPVS kernel module load, ipvsadm and ipset binaries
  • collect ipvs status and entry mapping

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Testing Done

  • Script execution
  • make tests passed

See this guide for recommended testing for PRs. Some tests may not apply. Completing tests and providing additional validation steps are not required, but it is recommended and may reduce review time and time to merge.

ipvsadm --list --numeric --rate | tee -a "${COLLECT_DIR}"/networking/ipvsadm.txt
ok -e "\n" | tee -a "${COLLECT_DIR}"/networking/ipvsadm.txt
ipvsadm --list --numeric --stats --exact | tee -a "${COLLECT_DIR}"/networking/ipvsadm.txt
ipset --list | tee -a "${COLLECT_DIR}"/networking/ipset.txt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, what if there have an old "${COLLECT_DIR}"/networking/ipset.txt existed for a long running node.

Copy link
Contributor Author

@AbeOwlu AbeOwlu Jun 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guessi cannot update tee to overwrite the same file ${COLLECT_DIR}"/networking/ipvsadm.txt here

  • can split out ipvsadm current config into separate files, but dont think that is necessary.
  • the first tee overwrite above should suffice if there is an existing file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also there is a cleanup func in the script, that removes the entire {COLLECT_DIR} used for work, I believe

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cartermckinnon @guessi do I need to replay this change on the latest base branch changes?

@Issacwww Issacwww merged commit c6e8ef0 into awslabs:main Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants