Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update lambda-http version to 0.13.0 #492

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jreppnow
Copy link

Issue #, if available:

Description of changes:

Updating version of lambda_http to address the issues explained in awslabs/aws-lambda-rust-runtime#852.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jreppnow jreppnow marked this pull request as ready for review August 15, 2024 07:00
@jreppnow
Copy link
Author

@maintainers Thanks for the crate! When executing the tests locally via cargo ttest_adapter_options_from_namespaced_env and test_http_readiness_check are failing, but when executed individually, the seem to pass. Personally, I think it's doubtful that this is caused by this PR (albeit I don't know the scope of all changes to the lambda crate), so I would appreciate some advise!

@bnusunny
Copy link
Contributor

bnusunny commented Aug 15, 2024

We use cargo nextest run to run each test in a seperate process.

Could you please add a test case in this file to cover this issue?

@jreppnow
Copy link
Author

@bnusunny Since this is/was a bug contained in a dependency I personally would not elect to write a test for it here, but I think I can come up with something!

@bnusunny bnusunny requested a review from a team as a code owner October 11, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants