Fix freq string issues in datasets #3232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lostella
added
bug fix
lostella
force-pushed
the
fix-datasets-freqs
branch
from
c8b4a90 to
eba268b
Compare
abdulfatir
approved these changes
Nov 5, 2024
lostella
added a commit
to lostella/gluonts
that referenced
this pull request
Nov 7, 2024
*Issue #, if available:* fixes awslabs#3229, pandas changes in frequency strings broke some of our logic. *Description of changes:* Add missing frequency strings in _tsf_datasets.py, and get rid of other frequency-related warnings with other datasets. I tested the change by running the following script: ```python from gluonts.dataset.repository import get_dataset, dataset_names skip = [ "m3_monthly", "m3_yearly", "m3_quarterly", "m3_other", "m5", ] for dataset_name in dataset_names: if dataset_name in skip: continue print(dataset_name) dataset = get_dataset(dataset_name, regenerate=True) ``` By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice. **Please tag this pr with at least one of these labels to make our release process faster:** BREAKING, new feature, bug fix, other change, dev setup
Merged
lostella
added a commit
that referenced
this pull request
Nov 7, 2024
*Description of changes:* Backporting PRs - #3228 - #3232 - #3233 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice. **Please tag this pr with at least one of these labels to make our release process faster:** BREAKING, new feature, bug fix, other change, dev setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: fixes #3229, pandas changes in frequency strings broke some of our logic.
Description of changes: Add missing frequency strings in _tsf_datasets.py, and get rid of other frequency-related warnings with other datasets. I tested the change by running the following script:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup