Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multiple CJS requires #630

Merged
merged 2 commits into from
Oct 17, 2024
Merged

fix: multiple CJS requires #630

merged 2 commits into from
Oct 17, 2024

Conversation

richarddavison
Copy link
Contributor

@richarddavison richarddavison commented Oct 16, 2024

Issue # (if available)

Fixes #610

Description of changes

require(...) imports should be cached and return same value for consecutive imports.

Checklist

  • Created unit tests in tests/unit and/or in Rust for my feature if needed
  • Ran make fix to format JS and apply Clippy auto fixes
  • Made sure my code didn't add any additional warnings: make check
  • Added relevant type info in types/ directory
  • Updated documentation if needed (API.md/README.md/Other)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@richarddavison richarddavison merged commit ec0dfb8 into main Oct 17, 2024
9 checks passed
@richarddavison richarddavison deleted the fix/cjs-multiple-require branch October 17, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: cannot read property 'HTTP' of undefined
1 participant