Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 11.x Compatibility #98

Closed
wants to merge 2 commits into from

Conversation

laravel-shift
Copy link
Contributor

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 11.x.

Before merging, you need to:

  • Checkout the l11-compatibility branch
  • Review all comments for additional changes
  • Thoroughly test your package

If you do find an issue, please report it by commenting on this PR to help improve future automation.

@laravel-shift
Copy link
Contributor Author

⚠️ The latest version of Laravel has a dependency for phpunit/phpunit of ^10.5. If you would like to also upgrade your tests, you may run the PHPUnit 10 Shift for free.

@laravel-shift
Copy link
Contributor Author

⚠️ Shift detected GitHub Actions which run jobs using a version matrix. Shift attempted to update your configuration for Laravel 11. However, you should review these changes to ensure the desired combination of versions are built for your package.

@laravel-shift
Copy link
Contributor Author

⚗️ Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.

To do so, temporarily add Shift's fork to the repositories property of your composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/laravel-visits.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:

{
    "require": {
        "awssat/laravel-visits": "dev-l11-compatibility",
    }
}

Finally, run: composer update

@BSN4
Copy link
Collaborator

BSN4 commented Mar 1, 2024

Tests failed need more work

@jasonmccreary
Copy link

My guess is these are dependency/CI related. For example, there isn't a 11.* constraint for Laravel yet. You would need to target dev-master or ^11.0 I believe works for Composer. Also, it's possible the underlying carbon\carbon dependency is 3.x on PHP 8.2 causing issues with Laravel 9.

@Mahan-Shoghy
Copy link

When this will publish?

@Jerimu
Copy link

Jerimu commented May 20, 2024

any news? This is my only package thats keeping me from upgrading to 11 right now.

@BSN4
Copy link
Collaborator

BSN4 commented May 22, 2024

any news? This is my only package thats keeping me from upgrading to 11 right now.

@Jerimu PRs are always welcome

@syntafin
Copy link

syntafin commented Jul 5, 2024

any news? This is my only package thats keeping me from upgrading to 11 right now.

@Jerimu PRs are always welcome

This is a PR for L11 compability

@BSN4
Copy link
Collaborator

BSN4 commented Jul 6, 2024

any news? This is my only package thats keeping me from upgrading to 11 right now.

@Jerimu PRs are always welcome

This is a PR for L11 compability

yeah but tests are failing sorry I don't have time to fix this PR.

@abdumu
Copy link
Member

abdumu commented Jul 6, 2024

Latest release supports Laravel 11 now.

@abdumu abdumu closed this Jul 6, 2024
@syntafin
Copy link

syntafin commented Jul 6, 2024

PR forgot to add Carbon ^3.0 in the depedencies for new created L11 projects - see #99

@abdumu
Copy link
Member

abdumu commented Jul 6, 2024

Laravel 11 supports both versions 2 and 3.

@syntafin
Copy link

syntafin commented Jul 6, 2024

Yes and new projects comes with 3, as I tried to require 6.1 in a fresh L11 project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants