Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(minor-interchain-token-service): ignore empty event attributes #656

Merged
merged 14 commits into from
Oct 15, 2024

Conversation

milapsheth
Copy link
Member

@milapsheth milapsheth commented Oct 11, 2024

Description

AXE-5913

Todos

  • Unit tests
  • Manual tests
  • Documentation
  • Connect epics/issues

Steps to Test

Expected Behaviour

Other Notes

@milapsheth milapsheth requested a review from a team as a code owner October 11, 2024 02:15
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 98.90710% with 4 lines in your changes missing coverage. Please review.

Project coverage is 93.73%. Comparing base (81b6061) to head (535c34e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/axelar-wasm-std/src/nonempty/hexbinary.rs 86.20% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #656      +/-   ##
==========================================
+ Coverage   93.69%   93.73%   +0.04%     
==========================================
  Files         243      244       +1     
  Lines       35678    35875     +197     
==========================================
+ Hits        33427    33628     +201     
+ Misses       2251     2247       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@milapsheth milapsheth merged commit c0fb73d into main Oct 15, 2024
8 checks passed
@milapsheth milapsheth deleted the fix/its-hub-events branch October 15, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants