Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(interchain-token-service): add message type SetChainConfig #669

Merged
merged 6 commits into from
Oct 29, 2024
Merged

feat(interchain-token-service): add message type SetChainConfig #669

merged 6 commits into from
Oct 29, 2024

Conversation

fish-sammy
Copy link
Collaborator

@fish-sammy fish-sammy commented Oct 28, 2024 •
edited
Loading

Description

Todos

  • Unit tests
  • Manual tests
  • Documentation
  • Connect epics/issues

Steps to Test

Expected Behaviour

Other Notes

@fish-sammy fish-sammy requested a review from a team as a code owner October 28, 2024 16:13
@fish-sammy fish-sammy force-pushed the AXE-6167-Set-chain-config-in-the-ITS-hub branch from 19f177d to 78c3c8e Compare October 28, 2024 16:16
@codecov Codecov
Copy link

codecov bot commented Oct 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.47%. Comparing base (4adfcef) to head (3a7d365).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #669      +/-   ##
==========================================
+ Coverage   93.45%   93.47%   +0.01%     
==========================================
  Files         237      237              
  Lines       34495    34535      +40     
==========================================
+ Hits        32239    32280      +41     
+ Misses       2256     2255       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cjcobb23
cjcobb23 approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@cjcobb23 cjcobb23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still have some outstanding comments, but not going to block on those, address them at your discretion. Looks good to me.

@fish-sammy fish-sammy force-pushed the AXE-6167-Set-chain-config-in-the-ITS-hub branch from 02fb925 to f558053 Compare October 29, 2024 18:33
@fish-sammy fish-sammy merged commit dc20405 into main Oct 29, 2024
8 checks passed
@fish-sammy fish-sammy deleted the AXE-6167-Set-chain-config-in-the-ITS-hub branch October 29, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milapsheth milapsheth milapsheth left review comments

@cjcobb23 cjcobb23 cjcobb23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fish-sammy @milapsheth @cjcobb23