Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: specify scrypt params explicitly #333

Merged
merged 18 commits into from
Jul 11, 2024
Merged

fix!: specify scrypt params explicitly #333

merged 18 commits into from
Jul 11, 2024

Conversation

milapsheth
Copy link
Member

@milapsheth milapsheth commented Jul 11, 2024 •
edited
Loading

AXE-2345

Also adds golden file based tests and updates some deps

@milapsheth milapsheth requested a review from sdaveas as a code owner July 11, 2024 01:57
sdaveas
sdaveas reviewed Jul 11, 2024
View reviewed changes
.gitmodules Show resolved Hide resolved
sdaveas
sdaveas approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@sdaveas sdaveas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@milapsheth milapsheth merged commit 1d3945f into main Jul 11, 2024
3 checks passed
@milapsheth milapsheth deleted the fix/scrypt-params branch July 11, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdaveas sdaveas sdaveas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@milapsheth @sdaveas