Add typescipt support and delopy to cf button #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bensigo
commented
Jul 24, 2023
Bensigo
commented
- Convert codebase to typescript
- add deploy to Cloudflare button
bahlo
reviewed
Jul 24, 2023
.github/workflows/deploy.yml
Outdated
| AXIOM_TOKEN: ${{ secrets.AXIOM_TOKEN }} | ||
| uses: cloudflare/wrangler-action@2.0.0 | ||
| with: | ||
| apiToken: ${{ secrets.CF_API_TOKEN }} |
There was a problem hiding this comment.
Adding a Deploy to Cloudflare button is part of the steps to follow, from the documentation
dasfmi
reviewed
Jul 24, 2023
dasfmi
reviewed
Oct 9, 2023
| const requestHeadersToCapture: string[] = ['user-agent']; | ||
| const responseHeadersToCapture: string[] = ['cf-cache-status', 'cf-ray']; | ||
|
|
||
| // 8< ----------- snip ------------ |
There was a problem hiding this comment.
seems like this comment was a left out
dasfmi
reviewed
Oct 9, 2023
|
|
||
| const WORKER_ID: string = generateId(6); | ||
|
|
||
| // const throttle = <T>(fn: Function, wait: number, maxLen: number, env: ENV) => { |
There was a problem hiding this comment.
if this is not needed we can remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.