AxmolActivity refactoring and fixes
#2185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also faced the popup issue and started a fix but saw this PR; I tried and it seems to work fine |
halx99
requested changes
Sep 27, 2024
core/platform/android/java/src/org/axmol/lib/AxmolGLSurfaceView.java
Outdated
Show resolved
Hide resolved
|
lgtm, merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors and simplifies how the state of the app activity is managed and also:
nativeOnResume()not being called after a system popup is displayed. (Easy repro: turn on bluetooth in quick settings menu and wait couple seconds for a popup to show up, then close it).AxmolRendererforgetting paused state whenAxmolActivityis relaunched, during which the old objects are destroyed and recreated. (Easy repro: in Android settings change global font size).I have tested this extensively on several devices, and everything seems to work. But it would be nice if more people tested it.