Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Scroll button on Contributors page #3164

Merged
merged 6 commits into from
Nov 10, 2024

Conversation

dipak2005
Copy link
Contributor

@dipak2005 dipak2005 commented Nov 9, 2024

πŸ› οΈ Fixes Issue

Fixes: #3148
Closes: #3148

πŸ‘¨β€πŸ’» Description :

improvement Code of toggle button on Contributors page

πŸ“„ Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (adds or updates related documentation)

πŸ“· Screenshots :

before changes :

Uploading Screen Recording 2024-11-09 214524.mp4…

after changes :

Screen.Recording.2024-11-10.140501.mp4

βœ… Checklist

  • I am a participant of GSSoC-ext.
  • I have followed the contribution guidelines of this project.
  • I have made this change from my own.
  • I have taken help from some online resources.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have added documentation to explain my changes.

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

🀝 GSSoC Participation

  • This PR is submitted under the GSSoC program.
  • I have taken prior approval for this feature/fix.

Copy link

vercel bot commented Nov 9, 2024

Deployment failed with the following error:

Resource is limited - try again in 8 minutes (more than 100, code: "api-deployments-free-per-day").

Copy link

github-actions bot commented Nov 9, 2024

Thank you for submitting your chaotic pull request! πŸ™Œ We'll review it as soon as possible. In the meantime, please ensure that your changes align with our chaotic CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Nov 9, 2024

βœ… Deploy Preview for getfinveda ready!

Name Link
πŸ”¨ Latest commit 9f28627
πŸ” Latest deploy log https://app.netlify.com/sites/getfinveda/deploys/67306f89c7c2c800082617d5
😎 Deploy Preview https://deploy-preview-3164--getfinveda.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 40
Accessibility: 66
Best Practices: 75
SEO: 73
PWA: 50
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

vercel bot commented Nov 9, 2024

Deployment failed with the following error:

Resource is limited - try again in 6 minutes (more than 100, code: "api-deployments-free-per-day").

Copy link

vercel bot commented Nov 9, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
fin-veda βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Nov 10, 2024 8:32am
finveda βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Nov 10, 2024 8:32am

@dipak2005 dipak2005 changed the title Fixing Toggle button on Contributors page Fixing Scroll button on Contributors page Nov 10, 2024
@dipak2005
Copy link
Contributor Author

@deepeshmlgupta , @sampadatiwari30 consider this pr.

@deepeshmlgupta
Copy link
Collaborator

solve the conficts in contributors.html

@dipak2005
Copy link
Contributor Author

@deepeshmlgupta I'm resolved this conflict plz consider this pr .

@deepeshmlgupta
Copy link
Collaborator

resolve these
image

also share the output video

@dipak2005
Copy link
Contributor Author

check this @deepeshmlgupta

@deepeshmlgupta deepeshmlgupta merged commit 45b8030 into ayush-that:main Nov 10, 2024
8 checks passed
@dipak2005 dipak2005 deleted the bug_fixer branch November 10, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: scroll button issue on Contributors page
2 participants