Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing footer on all pages #3178

Merged
merged 4 commits into from
Nov 10, 2024
Merged

Conversation

dipak2005
Copy link
Contributor

@dipak2005 dipak2005 commented Nov 10, 2024

πŸ› οΈ Fixes Issue

Fixes: #3177
Closes: #3177

πŸ‘¨β€πŸ’» Description

i'm improve the all footer's alignment and background colors and so on.

πŸ“„ Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (adds or updates related documentation)

πŸ“· Screenshots :

before changes :
Screenshot 2024-11-10 053026
Screenshot 2024-11-10 053515
Screenshot 2024-11-10 053806
Screenshot 2024-11-10 053756
Screenshot 2024-11-10 053748
Screenshot 2024-11-10 053727
Screenshot 2024-11-10 053718

after changes :

Screenshot 2024-11-10 061543
Screenshot 2024-11-10 061532
Screenshot 2024-11-10 061523
Screenshot 2024-11-10 061511
Screenshot 2024-11-10 061501
Screenshot 2024-11-10 061451
Screenshot 2024-11-10 061420
Screenshot 2024-11-10 061406

βœ… Checklist

  • I am a participant of GSSoC-ext.
  • I have followed the contribution guidelines of this project.
  • I have made this change from my own.
  • I have taken help from some online resources.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have added documentation to explain my changes.

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

🀝 GSSoC Participation

  • This PR is submitted under the GSSoC program.
  • I have taken prior approval for this feature/fix.

Copy link

vercel bot commented Nov 10, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
fin-veda βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Nov 10, 2024 9:05am
finveda βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Nov 10, 2024 9:05am

Copy link

Thank you for submitting your chaotic pull request! πŸ™Œ We'll review it as soon as possible. In the meantime, please ensure that your changes align with our chaotic CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Nov 10, 2024

βœ… Deploy Preview for getfinveda ready!

Name Link
πŸ”¨ Latest commit 3bd3d0b
πŸ” Latest deploy log https://app.netlify.com/sites/getfinveda/deploys/67307745b31477000872bf1b
😎 Deploy Preview https://deploy-preview-3178--getfinveda.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 40
Accessibility: 63
Best Practices: 75
SEO: 73
PWA: 50
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@dipak2005
Copy link
Contributor Author

@deepeshmlgupta , @sampadatiwari30
Kindly consider this pr.

@deepeshmlgupta
Copy link
Collaborator

solve conflicts in
contributors.html
faq.html

@dipak2005
Copy link
Contributor Author

@deepeshmlgupta i resolve it , check this pr.

@deepeshmlgupta
Copy link
Collaborator

image
@dipak2005 solve it

@dipak2005
Copy link
Contributor Author

Screenshot 2024-11-10 143551
done sir @deepeshmlgupta

@deepeshmlgupta deepeshmlgupta merged commit f9355a7 into ayush-that:main Nov 10, 2024
8 checks passed
@dipak2005 dipak2005 deleted the branch1.0 branch November 10, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: footer alignment and background issues
2 participants