Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct styling of social icons in careers.html modal #3317

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

akshay0611
Copy link
Contributor

πŸ› οΈ Fixes Issue

Fixes: #3316

πŸ‘¨β€πŸ’» Description

What does this PR do?

This PR addresses the issue of improper alignment of social icons in the login modal and register modal on the careers.html page. The icons were previously displayed vertically, and this update ensures that they are now displayed horizontally, improving the user interface.

  • Feature Implemented: Social icons are now aligned horizontally within both the login and register modals.
  • Motivation: This enhances the layout and ensures the social media icons are more accessible and visually appealing.
  • Dependencies: No external dependencies were required for this change.

πŸ“„ Type of Change

  • [] Bug fix (non-breaking change which fixes an issue)
  • [βœ…] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (adds or updates related documentation)

πŸ“· Screenshots/GIFs (if any)

Include before and after screenshots of the updated layout for the social icons in the login and register modals.

  • Before:

image

  • After:

image

βœ… Checklist

  • [] I am a participant of GSSoC-ext.
  • [βœ…] I have followed the contribution guidelines of this project.
  • [βœ…] I have made this change from my own.
  • [] I have taken help from some online resources.
  • [βœ…] My code follows the style guidelines of this project.
  • [βœ…] I have performed a self-review of my own code.
  • [] I have added documentation to explain my changes.

Mandatory Tasks

  • [βœ…] Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

🀝 GSSoC Participation

  • [] This PR is submitted under the GSSoC program.
  • [] I have taken prior approval for this feature/fix.

Copy link

vercel bot commented Nov 20, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
finveda βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Nov 20, 2024 7:33am

Copy link

Thank you for submitting your chaotic pull request! πŸ™Œ We'll review it as soon as possible. In the meantime, please ensure that your changes align with our chaotic CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[style]: Social Icons Styling Fix
1 participant