-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: makes partitionByComment
support line
and block
filters
#433
Open
hugop95
wants to merge
20
commits into
azat-io:main
Choose a base branch
from
hugop95:feat/partition-by-comment
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+4,753
−120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugop95
force-pushed
the
feat/partition-by-comment
branch
4 times, most recently
from
December 25, 2024 12:34
b06e023
to
3200b45
Compare
- Uses object-based parameters. - Moves `hasPartitionComment` to its own file.
hugop95
force-pushed
the
feat/partition-by-comment
branch
from
December 25, 2024 12:44
3200b45
to
fe4841f
Compare
hugop95
force-pushed
the
feat/partition-by-comment
branch
from
December 25, 2024 15:32
fe4841f
to
cb30325
Compare
hugop95
force-pushed
the
feat/partition-by-comment
branch
3 times, most recently
from
December 25, 2024 18:15
4a7198e
to
4b5cd3b
Compare
hugop95
force-pushed
the
feat/partition-by-comment
branch
from
December 25, 2024 23:46
4b5cd3b
to
731bbe1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #432
Most of the lines added are tests and documentation.
Description
Updates the
partitionByComment
option to supportblock
andline
filters:Affected rules
sort-enums
sort-array-includes
sort-sets
sort-decorators
sort-object-types
sort-interfaces
sort-modules
sort-classes
sort-variable-declarations
sort-union-types
sort-intersection-types
sort-objects
sort-named-imports
sort-named-exports
sort-maps
sort-imports
sort-exports
What is the purpose of this pull request?