add the privilege entry #53
Conversation
| const person = await projectService.addPersonToProject(params); | ||
|
|
||
| await addUserPrivilege( | ||
| person.principalUri, |
There was a problem hiding this comment.
hey @evert, this is giving me an error.
Also, wondering if I was on the right track. My intuition is, I should also be adding the project.href instead of the person.href on line 27.
There was a problem hiding this comment.
I think this section should go into the projectService instead, because it's all part of 'adding a person to a project'. There you should also not have this issue because you always have a principalUrl.
| params.role, | ||
| new URL(project.href, ctx.request.origin), | ||
| ); | ||
| await projectService.addPersonToProject(params, projectId, origin); |
There was a problem hiding this comment.
So this object is now starting to look really weird. What are params, what aren't params? Why are some things in params? Decide on a path, either a parameters object, or do every argument separately.
Also generally avoid passing something like a projectId, you always want to pass the full object.
| return person; | ||
| project = await findById(projectId); | ||
|
|
||
| } finally { |
There was a problem hiding this comment.
This is not a good use of finally. Just leave this outside of this block. It now runs even if there's other errors happening, and we really don't want that.
Changes
addPersonToProject()now returns aPersonaddUserPrivilegein theperson-collection, we are adding the new Person as a with the designated role