Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove obsolete [CratesSize] test for null size #10688

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

jNullj
Copy link
Contributor

@jNullj jNullj commented Nov 21, 2024

Eliminate a test case that is no longer relevant due to upstream changes that removed all null crate sizes.

see also upstream merge that removed null for versions.crate_size upstream at rust-lang/crates.io#9926

changes upstream removed all null crate_size
see also rust-lang/crates.io#9926
@jNullj jNullj added the keep-service-tests-green Related to fixing failing tests of the services label Nov 21, 2024
Copy link
Contributor

github-actions bot commented Nov 21, 2024

Messages
📖 ✨ Thanks for your contribution to Shields, @jNullj!

Generated by 🚫 dangerJS against 0c0b0b0

@chris48s
Copy link
Member

If we don't expect to receive null sizes any more, then we shouldn't just delete the test. We should update/remove the application code that deals with that situation as well:

crate_size: nonNegativeInteger.allow(null),

if (size == null) {
throw new InvalidResponse({ prettyMessage: 'unknown' })
}

@jNullj jNullj added this pull request to the merge queue Nov 26, 2024
Merged via the queue into badges:master with commit e8e253d Nov 26, 2024
23 checks passed
@jNullj jNullj deleted the fix/service-test-green/CratesSize branch November 26, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep-service-tests-green Related to fixing failing tests of the services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants