Eliminate variant in version comparison for takeover action #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we need to be concerned with the '.prod' variant as well? I have not seen this used. |
kb2ma
changed the title
kb2ma
force-pushed
the
strip-variant-comparison
branch
from
8ec3ba5 to
913a23f
Compare
|
Added a second commit that extends the first to check for .prod as well as .dev. I can either squash down if we need both tests, or remove the second commit if we don't. |
kb2ma
changed the title
thgreasi
reviewed
Dec 13, 2024
thgreasi
reviewed
Dec 13, 2024
thgreasi
approved these changes
Dec 16, 2024
The variant may be appended by balena-proxy. Change-type: patch Signed-off-by: Ken Bannister <kb2ma@runbox.com>
kb2ma
force-pushed
the
strip-variant-comparison
branch
from
ce66988 to
b0e0a62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This variant may be appended by balena-proxy.
Change-type: patch