Adding toArray() and getDomain() function #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding the method toArray which returns all values given to the class. This will be helpfull if somebody will save the result as json or xml
make also the `urls` parameter to an array
|
Thanks for opening this pull request! Please check out our contributing guidelines. |
|
Congrats on merging your first pull request! We here at Baraja are proud of you! |
|
Thank you. ❤️ |
|
You're welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added to the classes
Baraja\WebCrawler\Entity\CrawledResultandBaraja\WebCrawler\Entity\Urlthe methodtoArray, which returns all data from the class as array.I've also added
getDomainfunction to theBaraja\WebCrawler\Entity\Urlclass. Which is only an alias.