chore: Boolean Node unit tests #16
Conversation
|
Code Climate has analyzed commit 06adbe1 and detected 0 issues on this pull request. View more on Code Climate. |
|
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Code Health Quality Gates: OK
- Declining Code Health: 1 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Inconclusive -- Not enough commits to recommend a review strategy. The recommendation will be enabled automatically once you have more development activity.
View detailed results in CodeScene
🚩 Declining Code Health (highest to lowest):
- Code Duplication test_jl_boolean_nodes.py
| def test_statements(self): | ||
| eq1 = LogicEqualNode("a", "b") | ||
| eq2 = LogicEqualNode("c", "d") | ||
| node = BooleanAndNode(eq1, eq2) | ||
|
|
||
| assert node.to_asp(with_comment=True) == [ | ||
| "% a EQ b", | ||
| "eq(mock1) :- s0cc175b9c0f1b6a831c399e269772661 == s92eb5ffee6ae2fec3ad71c777531578f.", | ||
| "% c EQ d", | ||
| "eq(mock2) :- s4a8a08f09d37b73795649038408b5f33 == s8277e0910d750195b448797616e091ad.", | ||
| "and(mock3) :- eq(mock1), eq(mock2).", | ||
| ] |
There was a problem hiding this comment.
❌ New issue: Code Duplication
The module contains 8 functions with similar structure: TestBooleanAndNode.test_hash,TestBooleanAndNode.test_statements,TestBooleanAndNode.test_statements_false,TestBooleanAndNode.test_statements_true and 4 more functions
Why does this problem occur?
Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health. Read more.
To ignore this warning click here.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16 +/- ##
==========================================
+ Coverage 88.72% 91.72% +3.00%
==========================================
Files 28 28
Lines 816 834 +18
==========================================
+ Hits 724 765 +41
+ Misses 92 69 -23 ☔ View full report in Codecov by Sentry. |
No description provided.