chore: Add Translator unit tests #17
Conversation
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Code Health Quality Gates: OK
- Declining Code Health: 1 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 1 files(s) 🔥
Recommended Review Level: Inconclusive -- Not enough commits to recommend a review strategy. The recommendation will be enabled automatically once you have more development activity.
View detailed results in CodeScene
🚩 Declining Code Health (highest to lowest):
- Excess Number of Function Arguments test_rule_generator.py: test_generate_multiple_rule_asp_definition 🔥
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17 +/- ##
==========================================
+ Coverage 91.72% 95.00% +3.27%
==========================================
Files 28 28
Lines 834 840 +6
==========================================
+ Hits 765 798 +33
+ Misses 69 42 -27 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
✅ Code Health Quality Gates: OK
- Declining Code Health: 1 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 1 files(s) 🔥
Recommended Review Level: Inconclusive -- Not enough commits to recommend a review strategy. The recommendation will be enabled automatically once you have more development activity.
View detailed results in CodeScene
🚩 Declining Code Health (highest to lowest):
- Excess Number of Function Arguments test_rule_generator.py: test_generate_multiple_rule_asp_definition 🔥
| def test_generate_multiple_rule_asp_definition( | ||
| rule_inputs, with_comments, custom_nodes, expected_statements, expected_mapping | ||
| ): | ||
| statements, mapping = generate_multiple_rule_asp_definition( | ||
| rule_inputs=rule_inputs, | ||
| with_comments=with_comments, | ||
| custom_nodes=custom_nodes, | ||
| ) | ||
|
|
||
| assert statements == "\n".join(expected_statements) | ||
| assert mapping == expected_mapping |
There was a problem hiding this comment.
❌ New issue: Excess Number of Function Arguments
test_generate_multiple_rule_asp_definition has 5 arguments, threshold = 4
Why does this problem occur?
This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments. Read more.
To ignore this warning click here.
|
Code Climate has analyzed commit 46c9cf1 and detected 0 issues on this pull request. View more on Code Climate. |
There was a problem hiding this comment.
✅ Code Health Quality Gates: OK
- Declining Code Health: 1 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 1 files(s) 🔥
Recommended Review Level: Inconclusive -- Not enough commits to recommend a review strategy. The recommendation will be enabled automatically once you have more development activity.
View detailed results in CodeScene
🚩 Declining Code Health (highest to lowest):
- Excess Number of Function Arguments test_rule_generator.py: test_generate_multiple_rule_asp_definition 🔥
|
No description provided.