feat: Add support for booleans in Logic If node #21
Conversation
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Code Health Quality Gates: OK
- Declining Code Health: 2 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 1 files(s) 🔥
Recommended Review Level: Inconclusive -- Not enough commits to recommend a review strategy. The recommendation will be enabled automatically once you have more development activity.
View detailed results in CodeScene
🚩 Declining Code Health (highest to lowest):
- Code Duplication test_jl_logic_nodes.py
- Bumpy Road Ahead jl_logic_nodes.py: JsonLogicHelperBoolNode.get_asp_statements 🔥
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 28 29 +1
Lines 853 885 +32
=========================================
+ Hits 853 885 +32 ☔ View full report in Codecov by Sentry. |
|
Code Climate has analyzed commit e0265e5 and detected 0 issues on this pull request. View more on Code Climate. |
|
There was a problem hiding this comment.
✅ Code Health Quality Gates: OK
- Declining Code Health: 1 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Inconclusive -- Not enough commits to recommend a review strategy. The recommendation will be enabled automatically once you have more development activity.
View detailed results in CodeScene
🚩 Declining Code Health (highest to lowest):
- Code Duplication test_jl_logic_nodes.py
| @@ -45,16 +45,38 @@ def test_child_registration(self): | |||
|
|
|||
| assert node.child_nodes == [eq, gt] | |||
|
|
|||
| def test_child_registration_multiple_bool(self): | |||
There was a problem hiding this comment.
❌ Getting worse: Code Duplication
introduced similar code in: TestLogicIfNode.test_statements_if_cond,TestLogicIfNode.test_statements_if_cond_else,TestLogicIfNode.test_statements_if_cond_else_true,TestLogicIfNode.test_statements_if_false_cond_else and 1 more functions
Why does this problem occur?
Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health. Read more.
To ignore this warning click here.
No description provided.