Issue 6 fix #18

anupsv-cb · 2023-04-12T09:11:43Z

Fixes Issue

Closes #6

Changes proposed

Added goroutine management and "close" functions to be used for proper management of goroutines.
Added backtest functions
Added functionality of start and end heights, along with retries with editable config for number of retries.

Note to reviewers

Some changes can be made to improve, but leaving that for now since more structure of the project will define how to changes need to be made.

internal/conduit/pipeline/eth_client.go

internal/conduit/pipeline/oracle.go

internal/conduit/pipeline/types.go

internal/conduit/registry/geth_block.go

internal/conduit/registry/geth_block_test.go

internal/conduit/models/constants.go

internal/conduit/pipeline/oracle.go

internal/conduit/registry/geth_block.go

internal/client/eth_client.go

internal/conduit/registry/geth_block.go

epociask · 2023-04-14T09:55:40Z

@anupsv-cb reviewed, we should be good to go after this round though. Thank you for you contributions sir!

Co-authored-by: Ethen Pociask <ethen.pociask@coinbase.com>

epociask

LGTM

anupsv-cb added 10 commits April 7, 2023 13:30

small changes to documentation

e2112a9

Fixing config param types

e5eb129

Adding retries and configs to hold retry times.

65d8492

Major changes

32bab5c

Correct format for log

2635b7d

Adding eth client interface, config and tests.

ddd9d5c

Adding lint changes and new sub functions.

db5653f

fixing function called.

4d41331

fixing after go mod tidy

d85e412

renaming the variable.

0e82e82

epociask reviewed Apr 13, 2023

View reviewed changes

anupsv-cb added 2 commits April 13, 2023 18:05

Addressing all comments, adding more tests.

faff9b2

merging master

3e34960

anupsv-cb marked this pull request as ready for review April 14, 2023 01:20

anupsv-cb added 3 commits April 13, 2023 18:22

log changes and lint

50c5c8c

adding logs and fixing tests.

f468053

Fixing lint

2b8cc45

epociask reviewed Apr 14, 2023

View reviewed changes

anupsv-cb and others added 9 commits April 14, 2023 09:03

Update internal/conduit/pipeline/oracle.go

37581bb

Co-authored-by: Ethen Pociask <ethen.pociask@coinbase.com>

Fixing errors to log both errors.

f964bd0

Lint fixes.

402db60

Update internal/conduit/registry/geth_block.go

588d4c1

Co-authored-by: Ethen Pociask <ethen.pociask@coinbase.com>

Update internal/client/eth_client.go

63f29cf

Co-authored-by: Ethen Pociask <ethen.pociask@coinbase.com>

Update internal/client/eth_client.go

4236797

Co-authored-by: Ethen Pociask <ethen.pociask@coinbase.com>

go mod fixes.

0313ad3

go sum file

6acd922

Adding logging hooks (#25)

5836438

epociask approved these changes Apr 14, 2023

View reviewed changes

epociask merged commit 34ff89f into master Apr 14, 2023

nadir-akhtar-coinbase deleted the issue-6-fix branch June 26, 2023 22:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue 6 fix #18

Issue 6 fix #18

anupsv-cb commented Apr 12, 2023

epociask commented Apr 14, 2023

epociask left a comment

Issue 6 fix #18

Issue 6 fix #18

Conversation

anupsv-cb commented Apr 12, 2023

Fixes Issue

Changes proposed

Note to reviewers

epociask commented Apr 14, 2023

epociask left a comment

Choose a reason for hiding this comment