Deprecate --trusted. #1264
Merged
Deprecate --trusted. #1264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolasim
approved these changes
Dec 4, 2024
Co-authored-by: Bola Malek <bola@baseten.co>
marius-baseten
approved these changes
Dec 4, 2024
| @@ -1182,7 +1179,7 @@ def push( | |||
| tr, | |||
| model_name=model_name, | |||
| publish=publish, | |||
| trusted=trusted, | |||
| trusted=True, | |||
There was a problem hiding this comment.
I think it would be cleaner to strip this parameter/argument out of any functions / APIs and mace a change on the backend that hard-codes it to true.
|
Will follow-up with the changes marius proposed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 What
See thread for context:
--trustedflag is quite confusing for users, almost all of the time, you want to set it to true, but the default is false. At this point, from how people have been using Truss, there is not really a need for at all, and it serves as a major source of confusion.--trustedflag for Chains and never supported it.The behavior for secrets will now be that secrets will be mounted on the Truss. You still need to declare which secrets you want to access in the
config.yamlfile to access them. We throw a nice error in Truss if you try to access a secret that is not there.💻 How
🔬 Testing