Organize chains code. Separate 'remote' code. #1265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marius-baseten
force-pushed
the
marius/chains-org
branch
from
637f1aa to
b4633a3
Compare
marius-baseten
force-pushed
the
marius/chains-org
branch
from
1ed60e1 to
4423fac
Compare
squidarth
approved these changes
Dec 5, 2024
| parts.append( | ||
| _indent(f"result = {maybe_await}self._chainlet.{run_remote}({args})", 2) | ||
| ) | ||
| if chainlet_descriptor.endpoint.is_streaming: | ||
| # Streaming returns raw iterator, no pydantic model. | ||
| parts.append(_indent("return result")) | ||
| # This needs to be nested inside the `trace_parent` context! | ||
| parts.append(_indent("async for chunk in result:", 2)) |
There was a problem hiding this comment.
just to be clear, the problem with just returning the result is that the actual generator executes outside of the context of the trace parent right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 What
stub.py->remote_chainlet.utils.py.fastapidependency to defaults, since chains needs it (still) - current release is broken in that regard.def predict(...).Note: at the surface level, the chains API stays the same, through the uniform export of symbols in
__ini__.py.💻 How
🔬 Testing