Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix initialization from pydantic models #1281

Merged
merged 2 commits into from
Dec 11, 2024
Merged

fix initialization from pydantic models #1281

merged 2 commits into from
Dec 11, 2024

Conversation

joostinyi
Copy link
Collaborator

🚀 What

  • Added validation of TRTLLM configuration was failing when using pydantic models in constructor – this PR adds a check to only apply the validation in ambiguous cases when constructing from a dictionary.

💻 How

🔬 Testing

  • Added unit test coverage for this case

@joostinyi joostinyi requested a review from bdubayah December 11, 2024 22:17
@joostinyi joostinyi merged commit 80a965b into main Dec 11, 2024
4 checks passed
@joostinyi joostinyi deleted the jyi/fix-trt-llm-init-from-pydantic-models branch December 11, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdubayah bdubayah bdubayah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joostinyi @bdubayah