Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding 5min timeout to internal nginx proxy #670

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

aspctu
Copy link
Collaborator

@aspctu aspctu commented Sep 19, 2023

Overview

For TGI and vLLM, we use a nginx proxy to re-route prediction requests to the correct underlying path. Nginx, however, has a 60 second default timeout which affects longer generation requests. This PR updates this timeout to be 5 mins.

We use the proxy_read_timeout directive here (instead of proxy_send_timeout) as it sets the timeout for reading a response from the proxied server vs. setting a timeout for sending a request to the proxied server.

Testing

  • Tested manually on prod

@aspctu aspctu requested a review from squidarth September 19, 2023 16:39
@aspctu aspctu merged commit a47c226 into main Sep 20, 2023
3 checks passed
@aspctu aspctu deleted the abuqader/increase-nginx-proxy-timeout branch September 20, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants